Skip to content

Do not delete unused 3rd party index files #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 6, 2021

Previously, after removing a 3rd party URL from the preferences, the cached package_xxx_index.json was removed from the data directory. This fact would interfere with external tools like arduino-cli that may have a different set of external URLs.

Now the 3rd party indexes are left, this also leads to an overall simplification of the update/parsing process.

@cmaglie cmaglie requested a review from ubidefeo May 6, 2021 08:30
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working

@cmaglie cmaglie merged commit bc4498a into arduino:master May 6, 2021
@cmaglie cmaglie added this to the Release 1.8.14 milestone May 6, 2021
@cmaglie cmaglie deleted the do-not-delete-unused-packages-index branch May 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants